discuss page contents space fix #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthleslin
commented
May 27, 2024
darthleslin
commented
- Increased little bit of line height for the lines in the paragraph.
- Discuss page break tags removed and padding increased.
- space between the inner-text-box increased to 32px to maintain the uniformity between inside and outside of the wrappers.
Contributor
|
Can you show the screenshots before and after? |
Author
|
BEFORE AFTER |
michalsn
approved these changes
May 29, 2024
Arhell
approved these changes
May 30, 2024
Contributor
|
Thank you! |
darthleslin
force-pushed
the
leslin-patch-1
branch
from
430913b to
021aec4
Compare
Author
Done. |
MGatner
approved these changes
Jun 6, 2024
Collaborator
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Thanks for this attention to detail! The only part I don't prefer is the bullet spacing feels too large (though I do agree a bit more space is warranted). But if others are in favor it's just an opinion.
kenjis
reviewed
Jun 7, 2024
kenjis
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.